Skip to content

Dismiss Duo Chat popup on QA login

Will Meek requested to merge qa_dismiss_duo_chat into master

What does this MR do and why?

!137896 (merged) adds a Duo Chat popup, unfortunately this led to selenium errors such as gitlab-org/release/tasks#7453 (closed)

This MR closes the popup on login.

Screenshots or screen recordings

n/a for this MR, see !137896 (merged) for frontend change this supports.

How to set up and validate locally

  • Run the test to prove out that this works locally as a control (Duo Chat popup not set but as a baseline you should not see Selenium::WebDriver::Error::ElementClickInterceptedError)
CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/browser_ui/9_data_stores/project/invite_group_to_project_spec.rb

Next, checkout the branch 425954-duo-chat-popover from !137896 (merged)

  • Set up GDK for the AI popup
    • I found it easiest to run this script (I didn't bother with keys as we are just interested in the popup) - $2554994
  • Set up the popup
rails console
Feature.enable(:tanuki_bot_breadcrumbs_entry_point)

When you login to GDK you should see the duo chat popup - DO NOT CLOSE

Run the test, it should fail

CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/browser_ui/9_data_stores/project/invite_group_to_project_spec.rb

with Selenium::WebDriver::Error::ElementClickInterceptedError

Next, apply the changes from this MR (branch qa_dismiss_duo_chat)

Run the test, it should not fail with Selenium::WebDriver::Error::ElementClickInterceptedError

CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/browser_ui/9_data_stores/project/invite_group_to_project_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tiffany Rea

Merge request reports

Loading