Skip to content

Added support for custom emoji in ancestor groups

Phil Hughes requested to merge revert-6f2f46a2 into master

What does this MR do and why?

Note This adds back in the changes from !137130 (merged) because it was reverted !138434 (merged)

Added support for custom emoji in ancestor groups

Updates the banzai filter to check for emojis in ancestor groups.

Updates the GraphQL query to allow for searching in ancestor groups.

SELECT DISTINCT ON (name) * FROM "custom_emoji" WHERE "custom_emoji"."namespace_id" IN (9970) ORDER BY "custom_emoji"."name" ASC, CASE WHEN namespace_id = 80 THEN 0 ELSE 1 END ASC

https://explain.depesz.com/s/25xr

When inside sub-group:

SELECT DISTINCT ON (name) * FROM "custom_emoji" WHERE "custom_emoji"."namespace_id" IN (9970, 1755573) ORDER BY "custom_emoji"."name" ASC, CASE WHEN namespace_id = 80 THEN 0 ELSE 1 END ASC

https://explain.depesz.com/s/lAWr

#426399 (closed)

Screenshots or screen recordings

How to set up and validate locally

  • Enable custom_emoji feature flag
  • Create a custom emoji in a group
  • Create a custom emoji in a subgroup
  • Visit an issue or merge request in the subgroup
  • Open the award emoji box and see both custom emojis

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports