Skip to content

Project storage: Hide if no permission

Sascha Eggenberger requested to merge project-storage-hide-if-no-permission into master

What does this MR do and why?

Project storage: Hide information if user has no permission

Based on this discussion in Slack: https://gitlab.slack.com/archives/C05CDGG7C5D/p1701419283999499

Because you don't know what 45.6GiB means. It's not only Files, it's other stuff too. However you can't see the breakdown so you might think "wow there are a lot of files in this repo better not clone this" - that is not helpful.

From https://gitlab.com/gitlab-org/gitlab/-/issues/322923#note_880457966

If you need to be a maintainer+ to view the usage quotas page, why even show the stat on the project overview to anyone below a maintainer? Do roles below maintainer care about storage at all, seeing that they aren't allowed to view the breakdown of it? Seems odd that we would say "This project is using 5 GiB, but you're not allowed to see why." I would almost rather hide the stat than unlink it.

cc @mvanremmerden @mle @mnearents

Screenshots or screen recordings

Before After
With permissions
permissions_before permissions_after
Without permissions
no_permissions_before no_permissions_after

How to set up and validate locally

  1. View project with admin permissions: http://gdk.test:3000/flightjs/Flight
  2. View as a logged out user: http://gdk.test:3000/flightjs/Flight

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to ✂️ UX Paper Cuts 16.7 → Project page (#430244 - closed)

Edited by Michael Le

Merge request reports

Loading