Show dismissal reason in pipeline security tab
What does this MR do and why?
Related #433336 (closed)
This shows the dismissal reason (if any) of dismissed findings in the table when the feature flag pipeline_security_dashboard_graphql
is enabled on the pipeline security tab.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Prerequisites
- You need an EE license
- You need to have runners enabled (See $2408961 for setting up a runner)
- Import https://gitlab.com/gitlab-examples/security/security-reports
- Run a pipeline on master
Validation
- Enable feature flag:
echo "Feature.enable(:pipeline_security_dashboard_graphql)" | rails console
- Go to the latest pipeline > security tab
- Click on a finding
- Click "Dismiss vulnerability" in the modal and select a dismissal reason
- Click "Confirm dismissal"
- Refresh page. Note: this will update automatically with #433509 (closed)
- Filter status by "All dismissal reasons"
- Validate you can see the finding you just dismissed with the dismissal reason badge
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Lorenz van Herwaarden