Skip to content

Simplify initialisation of What's New App

Lukas Eipert requested to merge leipert-simplify-whats-new-app into master

What does this MR do and why?

Simplify initalisation of Whats New App

We don't need to trigger the whats new app from the legacy top nav any longer. This allows us to simplify the init code in the super sidebar.

While we are at it, we are sneaking in a little rename of whats-new-app to js-whats-new-app. Also, we are now passing the version digest from the super sidebar, rather than reading it from the DOM attributes.

Screenshots or screen recordings

Before After
Screen_Recording_2023-12-06_at_10.25.49 Screen_Recording_2023-12-06_at_10.24.05

How to set up and validate locally

  1. Log into the GDK.
  2. Remove the localStorage item display-whats-new-notification (in the browser console with localStorage.removeItem('display-whats-new-notification')
  3. Reload the page
  4. The help menu should now a little dot, indicating that "what's new" has some entries.
  5. Open the drawer via Help > 'What's new'
  6. The dot should disappear, the drawer open
  7. Reloading the page: The help menu still should not have a dot

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miguel Rincon

Merge request reports