Remove remainder of old top nav bar layout
What does this MR do and why?
Remove What's New App related items from old nav
The new nav renders the What's New App perfectly on it's own. This means, we can remove these bits and pieces from the old nav. Note that this commit doesn't refactor some JavaScript bits, which now can be refactored, this will be done in a separate commit / MR.
Remove Help dropdown from legacy header
This removes the help dropdown and related partials from the app. They not rendered any longer. Goodbye and thank you for your service!
Note: The instance_review_permitted?
helper is seemingly unused. We
should double check, whether we missed introducing this behavior in the
new sidebar and whether we want to.
Remove "New Dropdown" from legacy top nav
The new dropdown is old news, so we can remove it. Interestingly it had
the last reference to .caret-down
, so we can get rid of it too! Also
interestingly the new nav still uses the new_dropdown_view_model
. But
we can look into slimming it down in a follow-up.
Remove default header layout and it's usage
That's it. We've done it. I assume we now can cleanup the header.scss even more, but we still have two layouts depending on it:
- app/views/layouts/header/_empty.html.haml
- app/views/layouts/header/_super_sidebar_logged_out.haml
But the cleanup now should be significantly easier.
Remove unused title partial
The only other usage was removed with: !139048 (merged)
Remove redundant navbar-sub-nav and navbar-nav styles
The other usages were removed with: !139048 (merged)
Screenshots or screen recordings
N/A, as the old nav isn't accessible any longer
How to set up and validate locally
N/A
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.