Save phone numbers of auto-banned users and show them in admin pages
cc @jayswain @gitlab-org/modelops/anti-abuse @gitlab-com/gl-security/security-operations/trust-and-safety
What does this MR do and why?
Implements https://gitlab.com/gitlab-org/modelops/anti-abuse/team-tasks/-/issues/517
- Save phone verification record when the number relates to a banned user
- Show other users with same phone number in admin user/abuse report pages
- Fix missing bottom margin on phone/credit card verification cards in admin show user page
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Set
export GITLAB_SIMULATE_SAAS=1
in theenv.runit
file in the GDK root (create if it doesn't exist) and rungdk restart
- Create some overlapping/non-overlapping
Users::PhoneNumberValidation
s on users, ideally thereported_user_XX
seeded users so there are already abuse reports- You can find the seeded reported users in your GDK admin
/admin/abuse_reports/
- example:
Users::PhoneNumberValidation.create(user: User.find_by_username("reported_user_18"), international_dial_code: 1, country: "US", phone_number: "123456789")
- You can find the seeded reported users in your GDK admin
- Check the show user page, abuse report page and linked matching phone number pages for the users
- The best place to start from this might be the
/admin/abuse_reports/
list, as you can get to the abuse report show pages (and then user/matches pages) from here.
- The best place to start from this might be the
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Ruby Nealon