Update issuable assignment change email copy
requested to merge 211470-assignee-change-email-notification-is-difficult-to-read-with-multiple-names into master
What does this MR do and why?
Indicate what users have been added as assignees and what users have been removed, rather than giving a full set of previous assignees and a full set of new assignees and leaving it to the user to determine what changed.
Includes updates to gitlab.pot with new base English strings and adjustments to tests in notify_spec.rb.
Screenshots
in the images below, the same change has been made to assignees in both the Before and After screenshot.
How to set up and validate locally
- Check out this branch locally and
gdk restart
- Navigate to an issue or an MR
- In a separate browser window or tab, navigate to
/rails/letter_opener
(for most devs, http://gdk.test:3000/rails/letter_opener)- This will let you observe system notification emails generated by user activity in your GDK
- On the issue or MR, change the assignees, then in the letter_opener window, check the resulting system notification email
- ADDING assignees
- Whenever 1 user is added as an assignee, the text should say
$NAME was added as an assignee.
- Whenever 2 users are added as assignees, the text should say
$NAME_1 and $NAME_2 were added as assignees.
- Whenever 3+ users are added as assignees, the text should say
$NAME_1, $NAME_2, .... and $NAME_n were added as assignees.
- Whenever 1 user is added as an assignee, the text should say
- REMOVING assignees
- Whenever 1 user is removed as an assignee but at least one assignee remains, the text should say
$NAME was removed as an assignee.
- Whenever 2 users are removed as assignees but at least one assignee remains, the text should say
$NAME_1 and $NAME_2 were removed as assignees.
- Whenever 3+ users are removed as assignees but at least one assignee remains, the text should say
$NAME_1, $NAME_2, .... and $NAME_n were removed as assignees.
- If the last assignee is removed, the text should say
All assignees were removed.
- Whenever 1 user is removed as an assignee but at least one assignee remains, the text should say
- ADDING AND REMOVING at the same time
- The appropriate combination of an added message and a removed message from the options above should both appear in the email. For example, if 1 assignee is added and two are removed, then there will be two paragraphs. The first will say
$NAME_1 was added as an assignee.
The second will say$NAME_2 and $NAME_3 were removed as assignees.
- The appropriate combination of an added message and a removed message from the options above should both appear in the email. For example, if 1 assignee is added and two are removed, then there will be two paragraphs. The first will say
- ADDING assignees
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #211470 (closed)
Edited by Chad Lavimoniere