Skip to content

Display settings panel for Dedicated

rossfuhrman requested to merge rf-sd-app-setting-for-dedicated into master

What does this MR do and why?

This is a follow-on to Add new pre-receive secret detection applicatio... (#428761 - closed).

Dedicated instances do not support feature flags, so we cannot rely on feature flags. This change is in support of the first iteration of pre-receive secret detection, which will be Experimental, and will roll out to Dedicated customers first.

With this change, we will show the application setting for pre receive secret detection based on whether or not the instance is Dedicated.

Changelog: changed

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Note: these instructions assume your local instance is not "Dedicated".

  1. Visit /admin/application_settings/security_and_compliance on your local instance.
  2. Note no Secret Detection section shows
  3. Make the following change in rails console:
setting = ApplicationSetting.first
setting.gitlab_dedicated_instance = true
setting.save!
  1. Refresh the Security & Compliance page
  2. Note the Secret Detection section now shows
  3. Expand the section and enable Secret Detection.
  4. The MR that does the secret detection may not be merged yet, so nothing further to do
  5. Optional: Cleanup by setting setting.gitlab_dedicated_instance = false and saving

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by rossfuhrman

Merge request reports