Skip to content

Emoji picker: Fix distorted custom Emojis

Sascha Eggenberger requested to merge emoji-fix-distorted-custom-emojis into master

What does this MR do and why?

Emoji picker: Fix distorted custom Emojis

There is some random CSS bleeding into custom Emojis:

// Fix issue with notes & lists creating a bunch of bottom borders.
li.note {
  img { max-width: 100%; }

  ...
}

where the loosly defined img selector is causing the issue.

History

Changes

  • This MR has cherry-picked the commits from !134111 (merged) (94894f73362b5a407b3fabc4419bd890e82de0a5, 853e15a2cde675b96af9eb91c61f9b0c0485ae52, 28201dfb43240df44e9af79a501a56ca76d67ca1)
  • Added the necessary changes to fix the regression

Screenshots or screen recordings

Before After
before2 after2
before after

How to set up and validate locally

  1. echo "Feature.enable(:custom_emoji)" | gdk rails c
  2. Create new Emoji: http://gdk.test:3000/groups/flightjs/-/custom_emoji/new
    name: party-parrot
    url: https://cultofthepartyparrot.com/parrots/hd/parrot.gif
  3. Go to an issue: http://gdk.test:3000/flightjs/Flight/-/issues/44

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #430244 (closed)
Closes #435048 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading