Skip to content

Awards: Fix alignment with custom Emojis

Sascha Eggenberger requested to merge awards-alignment-with-custom-emojis into master

What does this MR do and why?

Awards: Fix alignment with custom Emojis

With custom Emojis the buttons renders at 33.319px instead of 32px, also the vertical alignemnt is slightly off

Screenshots or screen recordings

Before After
before3 after3
before after
before_alignment after_alignment
reply_before reply_after

How to set up and validate locally

  1. echo "Feature.enable(:custom_emoji)" | gdk rails c
  2. Create new Emoji: http://gdk.test:3000/groups/flightjs/-/custom_emoji/new
    name: custom-cat
    url: https://upload.wikimedia.org/wikipedia/commons/thumb/1/1d/Katzepasstauf_%282009_photo%3B_cropped_2022%29_%28cropped%29.jpg/220px-Katzepasstauf_%282009_photo%3B_cropped_2022%29_%28cropped%29.jpg
  3. Go to an issue: http://gdk.test:3000/flightjs/Flight/-/issues/44 and add Emojis to a comment

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #430244 (closed), #424396 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading