Update Redis::BufferedCounter to use its own instrumentation
What does this MR do and why?
This MR updates Redis::BufferedCounter to use its own instrumentation. Separating BufferedCounter from SharedState's storage label allows us to deprecate ClusterSharedState in the future.
Step 2 of gitlab-com/gl-infra/scalability#2651 (comment 1693732965)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- On a
gdk rails console
, we see that theinstrumentation_class
is not overriden
[1] pry(main)> Gitlab::Redis::BufferedCounter.params
=> {:instrumentation_class=>Gitlab::Instrumentation::Redis::BufferedCounter, :path=>"/Users/sylvesterchin/work/gitlab-development-kit/redis/redis.socket", :db=>0}
- On master branch, it is overriden
[1] pry(main)> Gitlab::Redis::BufferedCounter.params
=> {:instrumentation_class=>Gitlab::Instrumentation::Redis::SharedState, :path=>"/Users/sylvesterchin/work/gitlab-development-kit/redis/redis.socket", :db=>0}
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Sylvester Chin