Remove show_super_sidebar? helper
What does this MR do and why?
Remove new_nav attribute from snowplow context
We now always render the new nav, so we can remove this boolean toggle from the snowplow context.
Remove super sidebar helper from user profile
The helper was just used to conditionally apply some margins / hide another bit of code. There likely is more code to be removed, but the user profile code is a little complex and there is a dedicated follow-up issue: #435457 (closed)
Remove show_super_sidebar? test in page layout
Given the super sidebar will now always be shown, we can simplify the template here a little bit. The elsif path should have been removed with: !138342 (merged)
Remove show_super_sidebar? helper
It's done. It isn't anymore, so we can remove it.
Remove new_nav attribute from snowplow context
We now always render the new nav, so we can remove this boolean toggle from the snowplow context.
Screenshots or screen recordings
N/A, no changes. Even the user profile looks the same as before:
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- The sidebar still works
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.