Skip to content

Simplified labels FF

Sascha Eggenberger requested to merge simplified-labels-ff into master

What does this MR do and why?

Simplified labels FF: Reduce label variants down to a single size, one size fits all 🎉

What

This MR introduces the FF :simplified_labels:

For testing purposes we moved the changes from GitLab UI gitlab-ui!3306 (merged) directly to GitLab as this is a change which spans over the hole product and can make a lot of impacts.

Once verified we'll move things to GitLab UI and remove those overrides again from the product.

Variant Before After
sm label_sm_before label_after
md label_md_before label_after

Why

In gitlab-ui!3306 (merged) we try to reduce the GlLabel variants down to a single size to:

  • Increase hit target for small labels
  • Ease the developer experience
  • Streamline the use of labels

For easier testing we temporarily bring the updated label styles to GitLab (behind this FF) and once verified we can refactor GitLab and move the styles into GitLab UI (MR: gitlab-ui!3306 (merged))

We've chosen a label size which is in between the current sm and md variants which is 20px height. This seems to be the ideal middle ground to also align nicely within text blocks (like used in the markdown/rich text editor).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

See gitlab-ui!3306 (merged)

How to set up and validate locally

  1. Enable FF echo "Feature.enable(:simplified_labels)" | rails c
  2. Verify labels are all the same size

Related to feat(label): Reduce label variants (gitlab-ui!3306 - merged), !140231 (merged), #424396 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading