Refactor `where_full_path_in` method on Routable
requested to merge 434118-follow-up-from-resolve-optimize-routable-where_full_path_in-by-avoiding-joins into master
What does this MR do and why?
This MR refactors the where_full_path
method on the Routable
module.
This MR replaces the method argument use_includes:
with preload_routes:
, which is more fitting as we do not use includes()
inside the method anymore. We eager-load routes specifically using preload()
, so it is easier to read and understand if the method argument also revealed this transparently.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #434118 (closed)
Edited by Manoj M J