Skip to content

Use theme 10 scale for navigation background

Scott de Jonge requested to merge super-sidebar-theme-use-10-scale into master

What does this MR do and why?

gitlab-ui!3871 (merged) introduces 10 scale values for each theme color palette. This allows us to remove the mix() SCSS color function from the theme helper and instead use explicit and documented color values.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

no visual changes screenshots for verification

Before After
gdk.test_3000_-_profile_preferences gdk.test_3000_-_profile_preferences
gdk.test_3000_-profile_preferences__1 gdk.test_3000_-profile_preferences__1
gdk.test_3000_-profile_preferences__2 gdk.test_3000_-profile_preferences__2
gdk.test_3000_-profile_preferences__3 gdk.test_3000_-profile_preferences__3
gdk.test_3000_-profile_preferences__4 gdk.test_3000_-profile_preferences__4
gdk.test_3000_-profile_preferences__5 gdk.test_3000_-profile_preferences__5
gdk.test_3000_-profile_preferences__6 gdk.test_3000_-profile_preferences__6
gdk.test_3000_-profile_preferences__7 gdk.test_3000_-profile_preferences__7
gdk.test_3000_-profile_preferences__8 gdk.test_3000_-profile_preferences__8
gdk.test_3000_-profile_preferences__9 gdk.test_3000_-profile_preferences__9
gdk.test_3000_-profile_preferences__10 gdk.test_3000_-profile_preferences__10

How to set up and validate locally

  1. Toggle navigation themes in http://gdk.test:3000/-/profile/preferences
  2. Ensure background color value is as expected

Merge request reports

Loading