Enable ci_data_ingestion_to_click_house by default
What does this MR do and why?
Enable ci_data_ingestion_to_click_house by default
Also remove the license check from there
We want to enable the creation of Ci::FinishedBuildChSyncEvent for everyone to simplify ClickHouse setup https://docs.gitlab.com/ee/ci/runners/runner_fleet_dashboard.html#enable-clickhouse-integration-and-features
See the discussion in Draft: Simplify ClickHouse feature flags for CI... (!140333 - closed)
This MR builds on top of Clear old Ci::FinishedBuildChSyncEvent's (!140739 - merged) which added garbage collection for those builds.
With this:
- it's easier to set up ClickHouse, because you need 1 fewer feature flag
- if you upgrade your licence, you can benefit from historical data
Concerns: it adds some small overhead to every EE instance, even if people never use CI analytics features. It should be very small though: those database rows are very small, and it's a single insert request to the database.
I do want to keep the feature flag though: if something goes wrong, people can at least disable it But I'm probably being too cautious.
Related issue: [Feature flag] Rollout of `generate_ci_finished... (#424866 - closed)
Changelog: added
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
No UI changes
How to set up and validate locally
- Configure ClickHouse with gdk https://docs.gitlab.com/ee/development/database/clickhouse/clickhouse_within_gitlab.html#gdk-setup (don't forget to run migrations)
- Create, run ci build and wait till it's finished
- visit runner dashboard via
admin area -> runners -> runner fleet dashboard
You should see a point on the chart in the bottom.