Skip to content

Mark clickhouse jobs unit so test files can be found

Lin Jen-Shin requested to merge treat-mark-clickhouse-jobs-unit into master

What does this MR do and why?

Mark clickhouse jobs unit so test files can be found

Where the files will be looked up is determined by TestLevel: tooling/quality/test_level.rb

In TEST_LEVEL_FOLDERS, we didn't define where clickhouse tests should be located. Following the previous implementation before !140792 (merged) they're located under directories considered unit tests.

While we can define a new clickhouse level so it can properly find where the tests are located, it's simpler to just follow whatever used for unit tests.

This is discovered at !140081 (comment 1715574958)

Minor gotcha

There's a gotcha though. If we have changes only happen in backstage-patterns, it'll run unit tests but not clickhouse tests.

For as-if-foss pipeline, it'll also run clickhouse tests because they're also considered unit tests, even when the main pipeline wouldn't run it.

This is minor and we can revisit later.

How to validate

Failing tests are intentional. The commit is removed after it's proven tested.

Edited by Lin Jen-Shin

Merge request reports