Skip to content

Ignore team review requested events on GitHub Import

Rodrigo Tomonari requested to merge rodrigo/fix-replay-events-importer into master

What does this MR do and why?

This MR fix a bug overlooked on the preview MR !139410 (merged)

review_requested and review_request_removed payload for team review requests use the attribute requested_team instead of requested_reviewer.

Since GitHub Import does not map team actions, such events are ignored.

This link has an example of a team review request event

Related to: #433536 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. Enable github_import_extended_events feature flag
  2. Use the command below to trigger a migration
curl --location 'http://gdk.test:3000/api/v4/import/github' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer GDK_ACCESS_TOKEN' \
--data '{
    "personal_access_token": "GITHUB_ACCESS_TOKEN",
    "repo_id": "REPO_ID",
    "target_namespace": "root",
    "new_name": "new-migrated-project",
    "optional_stages": {
      "attachments_import": false,
      "collaborators_import": false
    }
}'

Replace REPO_ID with the ID of a repository that has team review requests events

  1. Check if everything was migrated and no error was raised during the migration
Edited by Rodrigo Tomonari

Merge request reports