Skip to content

Minor style changes for onboarding popovers

Martin Wortschack requested to merge mw-onboarding-popover-fixes into master

What does this MR do?

This adds minor fixes for the onboarding popovers introduced in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13346 and https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13363

It adds the following changes:

  • Increase button size in popovers from xs to sm
  • Changes popover class name to onboarding-popover
  • Utilize cssClasses prop of popover components for adding custom classes (so it adds onboarding-popover to the popover element itself)

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Martin Wortschack

Merge request reports

Loading