Skip to content

Fix accessibility issues in spam logs

Annabel Dunstone Gray requested to merge 425435-admin-browse-spec into master

What does this MR do and why?

  • Moves actions into single column
  • Fixes accessibility issue regarding empty th
  • Does not fix the link accessibility issue
Test output

Failures:

  1. Admin browse spam logs browse spam logs Got 1 failure and 1 other error:

    1.1) Failure/Error: expect(page).to be_axe_clean.within '.table'

       Found 2 accessibility violations:
    
       1) empty-table-header: Table header text should not be empty (minor)
           https://dequeuniversity.com/rules/axe/4.6/empty-table-header?application=axeAPI
           The following 1 node violate this rule:
    
               Selector: th:nth-child(11)
               HTML: <th></th>
               Fix any of the following:
               - Element does not have text that is visible to screen readers
    
       2) link-in-text-block: Links must be distinguishable without relying on color (serious)
           https://dequeuniversity.com/rules/axe/4.6/link-in-text-block?application=axeAPI
           The following 1 node violate this rule:
    
               Selector: a[href$="user1"]
               HTML: <a href="/admin/users/user1">Sidney Jones1</a>
               Fix any of the following:
               - The link has insufficient color contrast of 2.69:1 with the surrounding text. (Minimum contrast is 3:1, link text: #1f75cb, surrounding text: #333238)
               - The link has no styling (such as underline) to distinguish it from the surrounding text
Before After
Screenshot_2024-01-10_at_9.22.37_AM Screenshot_2024-01-10_at_9.22.07_AM

How to set up and validate locally

http://127.0.0.1:3000/admin/spam_logs

Links

Edited by Annabel Dunstone Gray

Merge request reports

Loading