Skip to content

Fix display of selected timezone for cities with duplicated identifiers

Thomas Hutterer requested to merge 372655-join-timezone-city-names into master

What does this MR do and why?

Fixes Timezone selection disappears after saving and ... (#372655 - closed).

🐛 TLDR: Some of the available timezones share the same identifier. Selecting and saving "London" showed "Edinburgh" after a page reload.

By merging these timezones into a single entry for the select box, joining their city names, we fix this confusing display bug.

Screenshots or screen recordings

Before After
recording_1704906095 recording_1704906002

How to set up and validate locally

  • Set "London" as new timezone in /-/profile and click the Update button.
  • All good, even on master (because UJS).
  • Now reload the page.
    • Before this fix, it now shows "Edinburgh" as your selected timezone.
    • With this fix, it should show "London". Same for other duplicates like "Mumbai/Chennai".
Edited by Thomas Hutterer

Merge request reports