Skip to content

Guard note components against `null` author field on note

Natalia Tepluhina requested to merge ntepluhina-guard-against-null-author into master

What does this MR do and why?

We plan to make author field on Note type nullable. This MR adds changes to frontend to handle the null author gracefully on Work Items and Design management

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No visual changes

How to set up and validate locally

  1. Open issues list and create a new objective from the dropdown
  2. Leave a few comments on the objective
  3. Change https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/work_items/components/notes/work_item_note.vue#L111 to return {}
  4. Make sure there are no console errors or visual glitches on work item view.
  5. Open any issue
  6. Upload a design
  7. Leave a few comments on the design
  8. Change https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/design_management/components/design_notes/design_note.vue#L104 to return {}
  9. Make the same checks on design notes
Edited by Natalia Tepluhina

Merge request reports