Skip to content

Increase the space between logo and tabs in sign in/up pages

Eduardo Sanz García requested to merge eduardosanz/space-between-logo-and-tabs into master

What does this MR do and why?

In the sign in/up pages increase the vertical space when there is custom text present.

In addition we made a couple of minor cleanup changes.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Apply this patch
diff --git a/app/views/layouts/devise.html.haml b/app/views/layouts/devise.html.haml
index 9d716ecf8e9b..7896e2fb1aa9 100644
--- a/app/views/layouts/devise.html.haml
+++ b/app/views/layouts/devise.html.haml
@@ -11,13 +11,13 @@
       .container.gl-align-self-center
         .content
           = render "layouts/flash"
-          - if custom_text.present?
+          - if true
             .row
               .col-md.order-12.sm-bg-gray
                 .col-sm-12
                   %h1.gl-mb-5.gl-font-size-h2
                     = brand_title
-                  = custom_text
+                  blah, blah
               .col-md.order-md-12
                 .col-sm-12.bar
                   .gl-text-center.gl-mb-5
  1. On an incognito window, go to /users/sign_in

Merge request reports