Resolve "User Onboarding: Calculate `percentageComplated` instead of using a hardcoded value"
requested to merge 12245-user-onboarding-calculate-percentagecomplated-instead-of-using-a-hardcoded-value into master
What does this MR do?
This MR removes the hardcoded percentageCompleted
value from the tour parts of the user onboarding contente.
Instead, the value is calculated based on the lastStepIndex
and the total number of steps for a particular tour.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #12245 (closed)
Edited by Martin Wortschack