Skip to content

Minor fixes for `Keeps::OverdueFinalizeBackgroundMigration` in CI

Dylan Griffith requested to merge keeps-overdue-finalize-require-rubocop into master

What does this MR do and why?

During CI I ran into 2 problems running this keep:

  1. Using RuboCop in this keep seemed to fail because we didn't require rubocop. I don't really know why this doesn't happen locally but in any case it seems like require 'rubocop' would be the correct thing to do
  2. There is something different about how the local git repo works (perhaps a detached HEAD) and switching back to the current branch failed because the current_branch was empty. In CI we don't need to worry about restoring to the current_branch

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Dylan Griffith

Merge request reports