Fix project subscriptions policy
What does this MR do and why?
Fix project subscriptions policy
The policy mistakenly required developer access to the downstream
project in order to read pipeline subscriptions, causing a problem in
the GraphQL endpoint relying on the :read_project_subscription
ability.
See #434831 (comment 1736956507)
Changelog: fixed
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
- as a Maintainer of a project viewing Settings --> CI/CD --> Pipeline Subscriptions: I can see all the subscribed and supscription projects listed correctly
✅ - as an Owner of a project viewing Settings --> CI/CD --> Pipeline Subscriptions: I can see all the subscribed and supscription projects listed correctly
✅
Further, I tested the graphql query on both the current(master branch
and fix-project-subscriptions-policy
with:
project(fullPath: "flightjs/Flight") {
ciSubscribers {
count
nodes {
downstreamProject {
name
namespace {
name
}
}
upstreamProject {
name
namespace {
name
}
}
}
}
ciSubscriptions {
count
nodes {
downstreamProject {
name
namespace {
name
}
}
upstreamProject {
name
namespace {
name
}
}
}
}
}
##The results
User Type | Before(current behaviour on master) | After (with changes in this MR) |
---|---|---|
Developer |
|
|
Maintainer |
|
|
Owner |
|
|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.