Remove misleading step from "Allow force push" instructions
What does this MR do?
The implication of the step I'm removing is that when Code owner approvals is enabled, it prevents a subset of users from pushing changes to files with code owners, who would otherwise be able to do so. However, this is not the case.
The infotip next to Code owner approvals says (correctly) that the setting does not prevent users allowed to push from doing so on files with code owners. That means that code owner approval only applies to users who aren't allowed to push to the branch anyway.
It seems like the line I've removed from the docs in this MR is a relic of old behavior of the feature that isn't true anymore, unless there's an edge-case I'm missing.
Impetus was this Zendesk ticket: https://gitlab.zendesk.com/agent/tickets/494202
cc @ashmckenzie to confirm that my understanding here is correct? (Sorry to single you out Ash, you were just the first Backend Engineer listed under the Source Code group
Related issues
Author's checklist
-
Optional. Consider taking the GitLab Technical Writing Fundamentals course. -
Follow the: -
If you're adding or changing the main heading of the page (H1), ensure that the product tier badge is added. -
If you are a GitLab team member, request a review based on: - The documentation page's metadata.
- The associated Technical Writer.
If you are a GitLab team member and only adding documentation, do not add any of the following labels:
~"frontend"
~"backend"
~"type::bug"
~"database"
These labels cause the MR to be added to code verification QA issues.
Reviewer's checklist
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.
If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.
-
If the content requires it, ensure the information is reviewed by a subject matter expert. - Technical writer review items:
-
Ensure docs metadata is present and up-to-date. -
Ensure the appropriate labels are added to this MR. -
Ensure a release milestone is set. - If relevant to this MR, ensure content topic type principles are in use, including:
-
The headings should be something you'd do a Google search for. Instead of Default behavior
, say something likeDefault behavior when you close an issue
. -
The headings (other than the page title) should be active. Instead of Configuring GDK
, say something likeConfigure GDK
. -
Any task steps should be written as a numbered list. - If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
-
-
-
Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.