Use component_version_id for project finder
What does this MR do and why?
Use component_version_id for project finder in place of component_id. As suggested in !141129 (comment 1729439592), this only address the functionality issue without addressing the variable renaming.
EE: true Changelog: fixed
Related issue: #438701 (closed)
The following files will have to wait until %17.0 in order to be updated:
DB migrate/rollback
$ bundle exec rails db:migrate
[warn]: @param tag has unknown parameter name: hide_units
in file `/Users/zamir/dev/gitlab-development-kit/gitlab/spec/components/previews/pajamas/single_stat_component_preview.rb' near line 18
main: == [advisory_lock_connection] object_id: 117860, pg_backend_pid: 84449
main: == 20240206105336 DeleteProjectIdComponentIdIndex: migrating ==================
main: -- transaction_open?(nil)
main: -> 0.0000s
main: -- view_exists?(:postgres_partitions)
main: -> 0.0122s
main: -- indexes(:sbom_occurrences)
main: -> 0.0054s
main: -- execute("SET statement_timeout TO 0")
main: -> 0.0002s
main: -- remove_index(:sbom_occurrences, {:algorithm=>:concurrently, :name=>"index_sbom_occurrences_on_project_id_component_id"})
main: -> 0.0046s
main: -- execute("RESET statement_timeout")
main: -> 0.0003s
main: == 20240206105336 DeleteProjectIdComponentIdIndex: migrated (0.0364s) =========
main: == [advisory_lock_connection] object_id: 117860, pg_backend_pid: 84449
ci: == [advisory_lock_connection] object_id: 118080, pg_backend_pid: 84451
ci: == 20240206105336 DeleteProjectIdComponentIdIndex: migrating ==================
ci: -- transaction_open?(nil)
ci: -> 0.0000s
ci: -- view_exists?(:postgres_partitions)
ci: -> 0.0006s
ci: -- indexes(:sbom_occurrences)
ci: -> 0.0056s
ci: -- execute("SET statement_timeout TO 0")
ci: -> 0.0004s
ci: -- remove_index(:sbom_occurrences, {:algorithm=>:concurrently, :name=>"index_sbom_occurrences_on_project_id_component_id"})
ci: -> 0.0033s
ci: -- execute("RESET statement_timeout")
ci: -> 0.0003s
ci: == 20240206105336 DeleteProjectIdComponentIdIndex: migrated (0.0629s) =========
$ bundle exec rails db:migrate:down:main VERSION=20240206105336
[warn]: @param tag has unknown parameter name: hide_units
in file `/Users/zamir/dev/gitlab-development-kit/gitlab/spec/components/previews/pajamas/single_stat_component_preview.rb' near line 18
main: == [advisory_lock_connection] object_id: 117500, pg_backend_pid: 84887
main: == 20240206105336 DeleteProjectIdComponentIdIndex: reverting ==================
main: -- transaction_open?(nil)
main: -> 0.0000s
main: -- view_exists?(:postgres_partitions)
main: -> 0.0121s
main: -- index_exists?(:sbom_occurrences, [:project_id, :component_id], {:name=>"index_sbom_occurrences_on_project_id_component_id", :algorithm=>:concurrently})
main: -> 0.0059s
main: -- execute("SET statement_timeout TO 0")
main: -> 0.0002s
main: -- add_index(:sbom_occurrences, [:project_id, :component_id], {:name=>"index_sbom_occurrences_on_project_id_component_id", :algorithm=>:concurrently})
main: -> 0.0097s
main: -- execute("RESET statement_timeout")
main: -> 0.0004s
main: == 20240206105336 DeleteProjectIdComponentIdIndex: reverted (0.0416s) =========
DB queries
Before
SELECT "projects"."id", "projects"."name", "projects"."path", "projects"."description", "projects"."created_at", "projects"."updated_at", "projects"."creator_id", "projects"."namespace_id", "projects"."last_activity_at", "projects"."import_url", "projects"."visibility_level", "projects"."archived", "projects"."avatar", "projects"."merge_requests_template", "projects"."star_count", "projects"."merge_requests_rebase_enabled", "projects"."import_type", "projects"."import_source", "projects"."approvals_before_merge", "projects"."reset_approvals_on_push", "projects"."merge_requests_ff_only_enabled", "projects"."issues_template", "projects"."mirror", "projects"."mirror_last_update_at", "projects"."mirror_last_successful_update_at", "projects"."mirror_user_id", "projects"."shared_runners_enabled", "projects"."runners_token", "projects"."build_allow_git_fetch", "projects"."build_timeout", "projects"."mirror_trigger_builds", "projects"."pending_delete", "projects"."public_builds", "projects"."last_repository_check_failed", "projects"."last_repository_check_at", "projects"."only_allow_merge_if_pipeline_succeeds", "projects"."has_external_issue_tracker", "projects"."repository_storage", "projects"."repository_read_only", "projects"."request_access_enabled", "projects"."has_external_wiki", "projects"."ci_config_path", "projects"."lfs_enabled", "projects"."description_html", "projects"."only_allow_merge_if_all_discussions_are_resolved", "projects"."repository_size_limit", "projects"."printing_merge_request_link_enabled", "projects"."auto_cancel_pending_pipelines", "projects"."service_desk_enabled", "projects"."cached_markdown_version", "projects"."delete_error", "projects"."last_repository_updated_at", "projects"."disable_overriding_approvers_per_merge_request", "projects"."storage_version", "projects"."resolve_outdated_diff_discussions", "projects"."remote_mirror_available_overridden", "projects"."only_mirror_protected_branches", "projects"."pull_mirror_available_overridden", "projects"."jobs_cache_index", "projects"."external_authorization_classification_label", "projects"."mirror_overwrites_diverged_branches", "projects"."pages_https_only", "projects"."external_webhook_token", "projects"."packages_enabled", "projects"."merge_requests_author_approval", "projects"."pool_repository_id", "projects"."runners_token_encrypted", "projects"."bfg_object_map", "projects"."detected_repository_languages", "projects"."merge_requests_disable_committers_approval", "projects"."require_password_to_approve", "projects"."max_pages_size", "projects"."max_artifacts_size", "projects"."pull_mirror_branch_prefix", "projects"."remove_source_branch_after_merge", "projects"."marked_for_deletion_at", "projects"."marked_for_deletion_by_user_id", "projects"."autoclose_referenced_issues", "projects"."suggestion_commit_message", "projects"."project_namespace_id", "projects"."hidden", "projects"."organization_id" FROM "projects" WHERE "projects"."namespace_id" IN (SELECT namespaces.traversal_ids[array_length(namespaces.traversal_ids, 1)] AS id FROM "namespaces" WHERE "namespaces"."type" = 'Group' AND (traversal_ids @> ('{58895632}'))) AND "projects"."id" IN (SELECT "sbom_occurrences"."project_id" FROM "sbom_occurrences" WHERE "sbom_occurrences"."component_id" = 1656) ORDER BY "projects"."id" DESC LIMIT 51;
After
SELECT "projects"."id", "projects"."name", "projects"."path", "projects"."description", "projects"."created_at", "projects"."updated_at", "projects"."creator_id", "projects"."namespace_id", "projects"."last_activity_at", "projects"."import_url", "projects"."visibility_level", "projects"."archived", "projects"."avatar", "projects"."merge_requests_template", "projects"."star_count", "projects"."merge_requests_rebase_enabled", "projects"."import_type", "projects"."import_source", "projects"."approvals_before_merge", "projects"."reset_approvals_on_push", "projects"."merge_requests_ff_only_enabled", "projects"."issues_template", "projects"."mirror", "projects"."mirror_last_update_at", "projects"."mirror_last_successful_update_at", "projects"."mirror_user_id", "projects"."shared_runners_enabled", "projects"."runners_token", "projects"."build_allow_git_fetch", "projects"."build_timeout", "projects"."mirror_trigger_builds", "projects"."pending_delete", "projects"."public_builds", "projects"."last_repository_check_failed", "projects"."last_repository_check_at", "projects"."only_allow_merge_if_pipeline_succeeds", "projects"."has_external_issue_tracker", "projects"."repository_storage", "projects"."repository_read_only", "projects"."request_access_enabled", "projects"."has_external_wiki", "projects"."ci_config_path", "projects"."lfs_enabled", "projects"."description_html", "projects"."only_allow_merge_if_all_discussions_are_resolved", "projects"."repository_size_limit", "projects"."printing_merge_request_link_enabled", "projects"."auto_cancel_pending_pipelines", "projects"."service_desk_enabled", "projects"."cached_markdown_version", "projects"."delete_error", "projects"."last_repository_updated_at", "projects"."disable_overriding_approvers_per_merge_request", "projects"."storage_version", "projects"."resolve_outdated_diff_discussions", "projects"."remote_mirror_available_overridden", "projects"."only_mirror_protected_branches", "projects"."pull_mirror_available_overridden", "projects"."jobs_cache_index", "projects"."external_authorization_classification_label", "projects"."mirror_overwrites_diverged_branches", "projects"."pages_https_only", "projects"."external_webhook_token", "projects"."packages_enabled", "projects"."merge_requests_author_approval", "projects"."pool_repository_id", "projects"."runners_token_encrypted", "projects"."bfg_object_map", "projects"."detected_repository_languages", "projects"."merge_requests_disable_committers_approval", "projects"."require_password_to_approve", "projects"."max_pages_size", "projects"."max_artifacts_size", "projects"."pull_mirror_branch_prefix", "projects"."remove_source_branch_after_merge", "projects"."marked_for_deletion_at", "projects"."marked_for_deletion_by_user_id", "projects"."autoclose_referenced_issues", "projects"."suggestion_commit_message", "projects"."project_namespace_id", "projects"."hidden", "projects"."organization_id" FROM "projects" WHERE "projects"."namespace_id" IN (SELECT namespaces.traversal_ids[array_length(namespaces.traversal_ids, 1)] AS id FROM "namespaces" WHERE "namespaces"."type" = 'Group' AND (traversal_ids @> ('{58895632}'))) AND "projects"."id" IN (SELECT "sbom_occurrences"."project_id" FROM "sbom_occurrences" WHERE "sbom_occurrences"."component_version_id" = 8365) ORDER BY "projects"."id" DESC LIMIT 51;
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Edited by Zamir Martins