Fix `z-index` for inline findings gutter icon
What does this MR do and why?
Remove gl-z-index-200
from inline findings icon
This keeps the icon from passing over the sticky file title when scrolling
because diffs.scss
sets the z-index of the .file-title
to 120
Changelog: fixed
EE: true
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screen_Recording_2024-02-14_at_16.31.50
Note: This also happens with the contents of the dropdown, but this MR only fixes the icon. I've opened an issue for the dropdown panel
How to set up and validate locally
🐛
reproduce the bug git checkout master
- clone/make a project that generates code quality results - I recommend this one
- make changes that result in new code quality violations in a new merge request, like this one
- ensure pipelines ran for the base and head commits of the merge request's branch
- scroll down through the diff and notice that the severity icons go in front of the file title panel when it sticks to the top
test the fix
-
git checkout fix-z-index-for-inline-findings-gutter-icon-dropdown
and refresh - scroll down again, the icons should now go behind the file title panel when it sticks to the top
🎉
Edited by Miranda Fluharty