Skip to content

Consider pipelines with supported sources for MR approval policy

Sashi Kumar Kumaresan requested to merge sk/428591-fix-parent-pipeline into master

What does this MR do and why?

This MR fixes a bug with MR approval policy comparison when a pipeline with sources other than Enums::Ci::Pipeline.ci_and_security_orchestration_sources are considered for applying approvals.

I was not able to reproduce the scenario, but from logs, we could see that pipeline_ids is empty:

Screenshot_2024-02-15_at_11.14.48_AM

More context: https://gitlab.com/gitlab-com/account-management/commercial/kingland-systems/-/issues/48#note_1773745869

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Addresses #428591 (closed)

Edited by Sashi Kumar Kumaresan

Merge request reports

Loading