Skip to content

Keep showing create issue loading spinner while redirecting

Lorenz van Herwaarden requested to merge show-create-issue-loading-spinner-while-redirecting into master

What does this MR do and why?

Related #440418 (closed)

This will make sure the loading spinner keeps showing while the redirection to the created issue in in progress. Before, the loading spinner would already stop showing once the mutation to create the issue was received.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
before after

With the MR applied and an error occurs, the loading spinner will still disappear:

error-no-loading

How to set up and validate locally

Prerequisites

  1. You need an EE license
  2. You need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/gitlab-examples/security/security-reports
  4. Run a pipeline on master

Validate

  1. Go to a pipeline and click the security tab
  2. Click on a finding (without a related issue)
  3. Set throttling in chrome devtools to slow 3G
  4. Click "Create issue"
  5. Validate that once the graphql mutation's response is received, the loading spinner keeps spinning
  6. Go back and click on another finding
  7. Make sure to set the network throttling to offline
  8. Click "Create issue"
  9. Validate that loading spinner is not showing

Merge request reports