Increase GraphQL complexity for fields that make gitaly calls (EE)
requested to merge 58409-increase-graphql-complexity-for-fields-that-make-gitaly-calls-ee into master
What does this MR do?
The GraphQL query complexity of a field should be increased if resolving that field makes at least one Gitaly call.
Also added is a Sentry error if the field needs to have calls_gitaly
declared, but is missing. The logic is not smart enough to know if it's conditional, just that at least one scenario it's true.
CE MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28814
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo