Skip to content

Move reusable Identity Verification controller code to a base controller

Eugie Limpin requested to merge el-create-base-iv-controller into master

What does this MR do and why?

Prep for https://gitlab.com/gitlab-org/modelops/anti-abuse/team-tasks/-/issues/629

Why

Currently users go through identity verification as part of the registration process. Moving forward, we want to allow users that have already started using Gitlab to go through identity verification to complete verification methods–phone number and/or credit card verification–that they didn't go through during registration in exchange for in-app benefits (e.g. more CI minutes).

What

In this MR we move controller code that are only relevant to identity verification during registration to a new RegistrationsIdentityVerificationController module and move all reusable controller code from IdentityVerificationController to a new BaseIdentityVerificationController module.

In a subsequent MR we will reintroduce IdentityVerificationController to house actions for identity verification that can be done outside the registration process.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

There are no behavior changes introduced in this MR so ensuring all existing tests are passing should be adequate.

Edited by Eugie Limpin

Merge request reports