Service Desk: Move full stop out of Learn more link
requested to merge gitlab-community/gitlab:414681-move-full-stop-out-of-learn-more-links-in-service-desk-settings into master
What does this MR do and why?
Move full stop out of Learn more link inside Service Desk settings
MR acceptance checklist
Screenshots or screen recordings
How to set up and validate locally
- Checkout this branch locally and start GDK
- Open a test project and go to Settings -> General
- Click on Expand inside the Service Desk section. You might not see any content if Service Desk is not enabled for the project. As a workaround, open
app/views/projects/_service_desk_settings.html.haml
and replace::Gitlab::ServiceDesk.supported?
withtrue
. This will force the Service Desk content to render. (You might need togdk restart
to see the changes) - Click the Activate Service Desk button.
- Locate the text
To add a custom suffix, set up a Service Desk email address. Learn more.
and verify that the full stop at the end is not part of the link - To see the alternative text we need to make sure Service Desk email is enabled. Go back to
app/views/projects/_service_desk_settings.html.haml
and replaceGitlab::Email::ServiceDeskEmail.enabled?
withtrue
. This will force the alternative content to render. - Locate the text
Add a suffix to Service Desk email address. Learn more .
and verify the full stop at the end is not part of the link
Related to #414681 (closed)