Migrate service_usage_data_download_payload_click to internal events
What does this MR do and why?
Related to gitlab-org/analytics-section/analytics-instrumentation/internal#714 (closed).
This migrates the counts.service_usage_data_download_payload_click
total count metric to Internal Events, while keeping the original Redis key. Instead of migrating the key to the new format in TotalCountMetric
, the new key is aliased in a YAML file and points to the old one, so that the count continues in the old key and we can keep the past count.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- Checkout
master
and fire the event a few times (click Download Payload button in Admin area). - Run in console and note the value:
definition = Gitlab::Usage::MetricDefinition.definitions['counts.service_usage_data_download_payload_click']
Gitlab::Usage::Metric.new(definition).with_value
- Checkout MR branch and run the code in the console again. The value should be identical.
- Fire the event a few more times and check if the value got incremented.
Edited by Piotr Skorupa