Remove category from Internal Events event definitions
requested to merge 435201-remove-category-from-internal-events-event-definitions-generator into master
What does this MR do and why?
As a last step to solve #435201 (closed) this MR addresses point 5) and 6) of the proposed solution.
Allow event definitions to have an optionalinternal_events
property and add it to a single event definitionMake the Metric Dictionary use theinternal_events
property instead ofcategory
ifinternal_events
is presentMakecategory
optional in the event definition schema. Migrate first batch of Internal Events event definitions to have nocategory
andinternal_events: true
Migrate the remaining event definitions- Modify the generator to output event definitions with
internal_events: true
instead ofcategory: InternalEventTracking
. - Modify the schema to make sure
category: InternalEventTracking
is not allow and migrate any event definition created after step 4 above.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Create a new event with the generator and verify that it doesn't have a
category
but hasinternal_events: true
. - Add
category: MyCategory
togitlab/config/events/p_analytics_ci_cd_deployment_frequency.yml
and see thatbundle exec rspec ./spec/lib/gitlab/tracking/event_definition_validate_all_spec.rb
fails.
Related to #435201 (closed)
Edited by Jonas Larsen