Allow user to approve for more than one group
Why
We want to allow users to approve a deployment for each group they are in that should be able to approve.
See: update Deployments::ApprovalService to let user... (#443683 - closed)
What
Use approval_rule_id in upsert query
This allows a user to create more than one approval through the service if there are unique represented_as fields.
-
Ensure the databse MR has been merged. -
Ensure the model update MR has been merged. -
Write failing spec to show user approving for multiple groups. -
Update Deployments::ApprovalService
and make spec pass.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Edited by Hunter Stewart