Skip to content

Fix GCP deployment name for the runner

Vladimir Shushlin requested to merge vshushlin/fix-runner-gcp-deployment-name-gen into master

What does this MR do and why?

Fix GCP deployment name for the runner

We have a validation that checks that it doesn't end with -

However both runner.short_sha and Devise.friendly_token can produce _.

That doesn't happen often, but flaky tests cought that:

[Test] ee/spec/services/ci/runners/create_googl... (#449152 - closed) • Unassigned

That MR just strips the end - from that string fixing the tests

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

I relied on tests

Merge request reports