Skip to content

Migrate deprecated native textarea in discussion_reply_placeholder.vue

Taras Tadai requested to merge 448818-migrate-textarea-in-reply-placeholder into master

What does this MR do and why?

Migrate usage of deprecated native textarea input in app/assets/javascripts/notes/components/discussion_reply_placeholder.vue. Usually it must be migrated to GlFormTextarea but in this case I found it's better to use GlFormInput as it looks like regular input field.

It's a part of Pajamas adoption project

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
reply_placeholder_old2 reply_placeholder_new2
reply_placeholder_old1 reply_placeholder_new1

How to set up and validate locally

Case 1

  1. Open some project
  2. Goto Plan -> Issues
  3. Open any existing issue or create a new one.
  4. Add a comment to issue.
  5. Reply to above comment.
  6. Verify Reply input field.

Case 2

  1. Enable GitLab Git Large File Storage config/gitlab.yml 
development:
  lfs:
    enabled: true
  1. Open the same issue from the Case 1
  2. Upload new design picture.
  3. Open that design(click on picture)
  4. Click on image and add a comment.
  5. Verify Reply input field.

Related to #448818 (moved)

Edited by Taras Tadai

Merge request reports