Skip to content

Add storage_shard label by decomposing instrumentation class name

Sylvester Chin requested to merge sc1-add-storage-shard-label into master

What does this MR do and why?

This MR adds the storage_shard label by decomposing instrumentation class name. The storage_shard label is obtained from the instrumentation class's name when it fits the <storage>_shard_<shard_name> format.

This MR would only affect Gitlab installations using sharded Sidekiq. The storage_shard: default label would be added for gitlab_redis_client_* metrics.

See issue: gitlab-com/gl-infra/scalability#2818 (comment 1828734089)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports