Cleanup removed files from RuboCop TODOs and rspec_order_todo.yml
What does this MR do and why?
This commit removes excludes from RuboCop TODOs and rspec_order_todo.yml
for removed/non-existent files.
Done via https://gitlab.com/-/snippets/2482940.
Follow-up of !134648 (merged).
How to set up and validate locally
# Check diff
git diff HEAD~
# Collect files removed
git diff HEAD~ | rg -r '$1' -o '^-\s+- (\S+)' | sort | uniq
# Check if they still exist via `stat`
git diff HEAD~ | rg -r '$1' -o '^-\s+- (\S+)' | sort | uniq | xargs stat -c "%n" {} 2>/dev/null
# No output
# Verify by touching a removed file
touch app/models/guest.rb
# Run again
git diff HEAD~ | rg -r '$1' -o '^-\s+- (\S+)' | sort | uniq | xargs stat -c "%n" {} 2>/dev/null
app/models/guest.rb
Git stats
.rubocop_todo/gitlab/namespaced_class.yml | 1 -
.../layout/first_hash_element_indentation.yml | 1 -
.rubocop_todo/layout/line_continuation_spacing.yml | 1 -
.rubocop_todo/layout/line_length.yml | 4 ---
.rubocop_todo/lint/assignment_in_condition.yml | 1 -
.rubocop_todo/qa/fabricate_usage.yml | 6 ----
.rubocop_todo/rails/migration_timestamp.yml | 1 -
.rubocop_todo/rails/pluck.yml | 1 -
.rubocop_todo/rspec/before_all_role_assignment.yml | 8 -----
.rubocop_todo/rspec/context_wording.yml | 6 ----
.rubocop_todo/rspec/expect_change.yml | 2 --
.rubocop_todo/rspec/factory_bot/avoid_create.yml | 2 --
.rubocop_todo/rspec/feature_category.yml | 14 ---------
.rubocop_todo/rspec/named_subject.yml | 11 -------
.../rspec/repeated_example_group_body.yml | 1 -
.rubocop_todo/rspec/return_from_stub.yml | 1 -
.rubocop_todo/rspec/verified_doubles.yml | 1 -
.../worker_data_consistency.yml | 5 ----
.rubocop_todo/style/arguments_forwarding.yml | 1 -
.rubocop_todo/style/explicit_block_argument.yml | 2 --
.rubocop_todo/style/format_string.yml | 1 -
.rubocop_todo/style/guard_clause.yml | 1 -
.rubocop_todo/style/inline_disable_annotation.yml | 4 ---
.rubocop_todo/style/missing_respond_to_missing.yml | 1 -
.rubocop_todo/style/string_concatenation.yml | 1 -
.../style/string_literals_in_interpolation.yml | 1 -
spec/support/rspec_order_todo.yml | 35 ----------------------
27 files changed, 114 deletions(-)
Edited by Peter Leitzen