Skip to content

Fix flaky login_spec.rb:1063 test

Eduardo Sanz García requested to merge eduardosanz/draft-sign-in-omniauth into master

What does this MR do and why?

Test spec/features/users/login_spec.rb:1063 failed for three reasons:

  • A race condition where request to assets where changing the _gitlab_session cookie value. This was fixed here: !148117 (merged)
  • The test was using the profile page that is in construction.
  • The test was clicking the Update profile setting button before jQuery initialized the form.

We have addressed the last two issues by:

  • Disabling the edit_user_profile_vue feature flag
  • Waiting for a data-testid attribute that is added once the jQuery initializes the form.

Closes #388049 (comment 1833370196)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No change

How to set up and validate locally

  • Run bundle exec rspec ./spec/features/users/login_spec.rb:1063
Edited by Eduardo Sanz García

Merge request reports