Move "Promote" to actions menu for milestone list pages
requested to merge 396753-move-promote-button-to-actions-menu-on-project-milestones-list into master
What does this MR do and why?
Removes the Promote button shown on milestone list pages and adds an action menu that includes edit, promote and delete actions depending on context.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Page | Before | After |
---|---|---|
Individual Milestone page in a project (no change) |
||
Individual Milestone page in a group (no change) |
||
Project milestone list page | ||
Group milestone list page | ||
Your work Milestone Dashboard list page |
How to set up and validate locally
- Check out this branch locally
- Restart your GDK. This is necessary in order to get the newly added index.js page added to the bundle.
- Visit a project milestones page
- You will see that there is a "Milestone actions" vertical-ellipse dropdown button on all the milestones. The "Promote to group milestone" icon button is no longer present.
- Open the milestone actions menu and you will see options to Close, Edit, Promote and Delete the milestone
- If you click edit, you will navigate to the edit page for the milestone
- If you click Promote, you will get a modal that checks if you are sure
- If you click "Promote milestone" in the modal, the milestone will be successfully promoted to a group milestone.
- If you click Delete, you will get a modal that checks if you are sure
- If you click "Delete milestone" in the modal, the milestone will be successfully deleted.
- Visit a group milestones page
- You will see that there is a "Milestone actions" vertical-ellipse dropdown button on all the milestones.
- Open the milestone actions menu and you will see options to Close, Edit and Delete the milestone
- The Milestone cannot be promoted from this page. There is no Promote option in the menu.
- If you click edit, you will navigate to the edit page for the milestone
- If you click Delete, you will get a modal that checks if you are sure
- If you click "Delete milestone" in the modal, the milestone will be successfully deleted.
- Visit the your work/milestones page
- You will see that there is a "Milestone actions" vertical-ellipse dropdown button on all the milestones.
- The menu has options to Close and Edit the milestone.
- The milestone cannot be promoted (if a project milestone) or deleted from here.
- If you click on one of the milestone action dropdown buttons, it will open a dropdown that only contains an Edit option
- If you click edit, you will navigate to the edit page for the milestone
- You will see that there is a "Milestone actions" vertical-ellipse dropdown button on all the milestones.
Related to #396753 (closed), #425467 (closed)
Edited by Chad Lavimoniere