Protected containers: Enable multi-line error messages in settings UI
requested to merge gitlab-community/gitlab:441345-gerardo-navarro-protected-contaioners-project-settings-ui-create-follow-up-alert-message into master
What does this MR do and why?
- Related to #441345 (closed)
- Add form for creating new container protection rule
- Refetch list of protection rules after submission
- This MR addresses the concerns and suggestions from this previous MR, see !146523 (comment 1845452291) and !146523 (comment 1852197356)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Enable Registry by editting
config/gitlab.yml
with the following setting
registry:
enabled: true
- Restart GDK, see also https://docs.gitlab.com/ee/administration/packages/container_registry.html#configure-container-registry-under-an-existing-gitlab-domain
gdk restart
- In rails console enable the experiment fully
Feature.enable(:container_registry_protected_containers)
- Go to http://gdk.test:3000/flightjs/Flight/-/settings/packages_and_registries
- In the section "Protected containers", click the button "Add protection rule" => a new form appears
- In the field "Repository path pattern", type the following value
asd!
- Click the button "Add rule"
- You should now see the errors in two lines instead of just one line.
Edited by Gerardo Navarro