Skip to content

Add pre_receive_secret_detection_enabled param

rossfuhrman requested to merge rf-permit-params-pre-rec-sd-beta into master

What does this MR do and why?

Add pre_receive_secret_detection_enabled param

Also add the pre_receive_secret_detection_enabled param when the pre_receive_secret_detection_beta_release feature flag is enabled. We are disabling a rubocop rule here temporarily because both the feature flag check and the Dedicated check will be removed in future iterations.

Changelog: added

With the implementation of Update admin settings interface for secret dete... (!148668 - merged) • Dheeraj Joshi • 16.11, we now utilize the pre_receive_secret_detection_beta_release feature flag for enabling/disabling this setting. This updates the code so that pre_receive_secret_detection_enabled is no longer an Unpermitted parameter when the feature flag is enabled.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Enable the new pre_receive_secret_detection_beta_release feature flag: Feature.enable(:pre_receive_secret_detection_beta_release)
  2. Go to http://gdk.test:3000/admin/application_settings/security_and_compliance
  3. Attempt to enable Pre-receive secret detecation
  4. Notice that it doesn't update the checkbox (unless you're already on the branch for this MR, in which case it should update the checkbox)
Edited by rossfuhrman

Merge request reports