Remove min and max_concurrency option in Sidekiq cluster
What does this MR do and why?
To remove the deprecated min_concurrency
and max_concurrency
options for sidekiq cluster CLI. This is mainly affecting self-managed instances.
We don't use the min-concurrency
and max-concurrency
options for GitLab.com. For GitLab.com we specify the concurrency here in k8s-workloads, which will then be passed as environment variable in the helm charts template, before finally passed as -c
(or --concurrency
) in CNG.
Deprecation announcement https://docs.gitlab.com/ee/update/deprecations.html#min-concurrency-and-max-concurrency-in-sidekiq-options
Part of gitlab-com/gl-infra/scalability#3422 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
❯ bin/sidekiq-cluster --dryrun --min-concurrency 10 --max-concurrency 20 'abcbc' 'qweqwe'
/Users/gregoriusmarco/Documents/workspace/gdk-10-22/gitlab/sidekiq_cluster/cli.rb:62:in `run': invalid option: --min-concurrency (OptionParser::InvalidOption)
from bin/sidekiq-cluster:11:in `<main>'
❯ bin/sidekiq-cluster --dryrun --concurrency 10 'abcbc' 'qweqwe'
bundle exec sidekiq -c10 -edevelopment -t25 -gqueues:default,mailers -r/Users/gregoriusmarco/Documents/workspace/gdk-10-22/gitlab -qdefault,1 -qmailers,1
bundle exec sidekiq -c10 -edevelopment -t25 -gqueues:default,mailers -r/Users/gregoriusmarco/Documents/workspace/gdk-10-22/gitlab -qdefault,1 -qmailers,1
# without concurrency option, default to 20
❯ bin/sidekiq-cluster --dryrun 'abcbc' 'qweqwe'
bundle exec sidekiq -c20 -edevelopment -t25 -gqueues:default,mailers -r/Users/gregoriusmarco/Documents/workspace/gdk-10-22/gitlab -qdefault,1 -qmailers,1
bundle exec sidekiq -c20 -edevelopment -t25 -gqueues:default,mailers -r/Users/gregoriusmarco/Documents/workspace/gdk-10-22/gitlab -qdefault,1 -qmailers,1