Skip to content

Add Sidekiq shard-awareness validator

Sylvester Chin requested to merge sc1-shard-awareness-validator into master

What does this MR do and why?

This MR adds a Sidekiq shard-awareness validator. The validator checks that all Gitlab's usage of Sidekiq API and Sidekiq.redis are within a Sidekiq::Client.via scope.

See issue: gitlab-com/gl-infra/scalability#2817 (comment 1864874290)

There is a follow-up issue to add shard-awareness for non-critical components (gitlab-com/gl-infra/scalability#3430). Those components do not need shard-awareness as the Sidekiq sharding feature is behing a feature flag. On .com, the migrations have been performed and cron-jobs do not need to be routed since they are polled by the default Sidekiq.redis.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Sylvester Chin

Merge request reports