Batching minutes reset queries in ClearSharedRunnersMinutesWorker
What does this MR do?
This MR addresses https://gitlab.com/gitlab-org/gitlab-ce/issues/65540 by refactoring ClearSharedrunnerMinutesWorker to clear Project- and NamespaceStatistics runner shared runner minutes on a batch of Namespace records as it is loaded to clear some notification-related attributes in the same job. The UPDATE query to project statistics times out and fails to clear the minutes, causing calculations to be incorrect until support fixes it for an account on a one-off basis.
Open concerns are listed in the comment section, please check out the conversations there and add any thoughts.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team