Skip to content

Protected containers: Use can_admin_all_resources? instead of user.admin? ContainerRegistryAuthService

  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

While working on the feature protected containers, I identified some pontential to improve the code with this MR.

  • Apply rubocop recommendations to use can_admin_all_resources? method instead of user.admin?
  • Use admin mode in tests admin mode is enabled in tests

🛠 with at Siemens

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

MR Checklist (@gerardo-navarro)

Screenshots or screen recordings

Only backend changes.

How to set up and validate locally

  1. Execute the test
bundle exec rspec spec/services/auth/container_registry_authentication_service_spec.rb
Edited by Gerardo Navarro

Merge request reports

Loading